Default value for BO4E-Versions without _version
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2023
hf-aschloegl
reviewed
Dec 1, 2023
| try: | ||
| return namespace["Angebot"].schema_parsed["properties"]["_version"]["default"] | ||
| except KeyError: | ||
| return "unknown" |
There was a problem hiding this comment.
Doofe Frage, aber wir sind ja aktuell deutsch unterwegs im BO4E Standard. Macht es dann Sinn den Default-Wert auch deutsch zu setzen?
There was a problem hiding this comment.
Also bisher waren z.B. alle doc strings, die technischer Natur waren, in Englisch. Und ich persönlich halte gerne alles in Englisch, was geht.
Hier geht es nur um einen Version-string, siehe hier: https://github.com/Hochfrequenz/intermediate-bo4e-migration-models/blob/22acb2fef03cf808b75a5e4ea2ea0673418b3f75/src/ibims/bo4e/__version__.py
hf-aschloegl
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.